gooneyryan/hermes-webui
1
0
Fork 0
mirror of https://github.com/nesquena/hermes-webui.git synced 2026-06-04 16:10:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge PR #3127 (jump-to-question on intermediate assistant msgs) into stage-batch43

Browse Source
This commit is contained in:
nesquena-hermes
2026-05-30 00:20:58 +00:00
parent c8afb37ae7 d45bc32c8d
commit 02e8a6ca8d
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/ui.js
+8 -2
View File
@@ -6494,8 +6494,14 @@ function renderMessages(options){
const tsTitle=tsVal?(_fmtSv?_fmtSv(new Date(tsVal*1000),{}):new Date(tsVal*1000).toLocaleString()):'';
const tsTime=_formatMessageFooterTimestamp(tsVal);
const timeHtml = tsTime ? `<span class="msg-time" title="${esc(tsTitle)}">${tsTime}</span>` : '';
const questionJumpBtn = (!isUser&&!m._live&&isTurnFinalAssistant)
? _questionJumpButtonHtml(questionRawIdxByAssistantRawIdx.get(rawIdx))
// #3114: show jump-to-question on every assistant message that has a
// resolvable question target, not just the turn-final one. Multi-step
// turns (tool_call -> assistant -> tool_call -> assistant) otherwise
// strip the button from every intermediate assistant bubble and the
// user loses the navigation affordance.
const _qJumpTarget=(!isUser&&!m._live)?questionRawIdxByAssistantRawIdx.get(rawIdx):undefined;
const questionJumpBtn = (_qJumpTarget!==undefined&&_qJumpTarget!==null)
? _questionJumpButtonHtml(_qJumpTarget)
: '';
const footHtml = `<div class="msg-foot">${timeHtml}<span class="msg-actions">${editBtn}${ttsBtn}${forkBtn}${copyBtn}${retryBtn}</span>${questionJumpBtn}</div>`;
tests/test_issue2246_question_jump.py
+8 -2
View File
@@ -15,8 +15,14 @@ def test_assistant_footer_gets_completed_turn_question_jump_button():
assert "questionRawIdxByAssistantRawIdx.set(entry.rawIdx,lastQuestionRawIdx)" in UI_JS
assert "row.id=_userMessageDomId(rawIdx)" in UI_JS
assert "const isTurnFinalAssistant=!isUser&&(!nextRendered||!nextRendered.m||nextRendered.m.role!=='assistant')" in UI_JS
assert "(!isUser&&!m._live&&isTurnFinalAssistant)" in UI_JS
assert "_questionJumpButtonHtml(questionRawIdxByAssistantRawIdx.get(rawIdx))" in UI_JS
# #3114 superseded the turn-final-only gate: the jump-to-question button now
# renders on every assistant message that has a resolvable question target,
# not just the turn-final one (multi-step turns otherwise lost the affordance
# on intermediate assistant bubbles). The button is gated on a non-null
# resolved target instead of isTurnFinalAssistant.
assert "const _qJumpTarget=(!isUser&&!m._live)?questionRawIdxByAssistantRawIdx.get(rawIdx):undefined;" in UI_JS
assert "const questionJumpBtn = (_qJumpTarget!==undefined&&_qJumpTarget!==null)" in UI_JS
assert "_questionJumpButtonHtml(_qJumpTarget)" in UI_JS
assert "msg-question-jump-btn" in UI_JS