mirror of
https://github.com/nesquena/hermes-webui.git
synced 2026-05-25 11:10:18 +00:00
Nathan Esquenazi
e8dbf94a6f
PR #2294 added the show_previous_messaging_sessions setting and a "Hide from list" menu action for external sessions, but tripped 8 tests: - 4 locale-parity tests (tests/test_{japanese,russian,spanish,chinese}_locale.py) demand every en key be defined in ja/ru/es/zh blocks. The contributor only added the 5 new keys to en + ko, leaving ja/ru/es/zh/it/de/zh-TW/pt/fr missing them. tests/test_provider_quota_status.py also requires the two settings_{label,desc}_previous_messaging_sessions keys in ALL 11 locales. - tests/test_1466_sidebar_cancel_clarify.py read the first 5200 chars of _openSessionActionMenu to find cancelSessionStream/delete actions; the new "Hide from list" branch (17 lines for external sessions) pushed those past the read window. - tests/test_issue1611_session_profile_filtering.py grep'd for the literal string `_keep_latest_messaging_session_per_source(scoped)`, which no longer exists after the call was rewritten as a multi-line keyword-arg form. Fixes: 1. Translations for the 5 new i18n keys added to all 9 missing locales (it, ja, ru, es, de, zh-CN, zh-TW, pt, fr): - session_hide_external - session_hide_external_desc - session_hidden - settings_label_previous_messaging_sessions - settings_desc_previous_messaging_sessions Where the locale already used the English fallback for related keys (ru/es/de session_archive), I provided localized translations for the new keys to match the project's general direction. Native-script quality, not machine-translation. 2. test_1466 window bumped 5200 → 6400 with a comment explaining the bump (mirrors the existing 3200→4400→5200 history annotations). 3. test_1611 dedupe-position check loosened to match the function name without the `(scoped)` suffix so it tolerates both single-line and keyword-arg call shapes. Tests: full suite 5828 passed / 63 skipped / 0 failed (was 8 failed). Behavioral harness verifies the toggle's claimed behavior — off (default) hides reset/compression segments, on shows all rows in timestamp order. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
