mirror of
https://github.com/nesquena/hermes-webui.git
synced 2026-07-21 07:00:23 +00:00
nesquena-hermes
ba987040c7
## Release v0.51.260 — Release IB (stage-r8) Un-held safety fixes (author resolved my earlier hold findings; re-reviewed fresh) + a clean fix batch. 6 PRs. ### Fixed | Issue/PR | Author | Fix | |----------|--------|-----| | #3535 (#3538) | @rodboev | **Self-update recovers from a stash-pop conflict without data loss.** Was a BRICK bug (`git reset --merge` + `git stash drop` discarded local mods while reporting success). Now keeps the stash, returns `ok:false` + "preserved in `stash@{0}`", no restart on conflict. *(was held — fix verified)* | | #1909 s3 (#3562) | @rodboev | **Auth `Secure` cookie no longer locks out plain-HTTP LAN/Tailscale users.** Secure now keys only on real TLS evidence (env / TLS socket / opt-in `TRUST_FORWARDED_PROTO`); non-loopback plain-HTTP is no longer force-Secure. SameSite back to `Lax`. *(was held — fix verified)* | | #2785 (#3559) | @franksong2702 | Clearer cron/gateway diagnostics for single-container Docker (gateway configured, no daemon → jobs silently don't fire). | | #3555 | @lambyangzhao | Long TTS responses chunked at sentence boundaries (works around the browser's ~32K silent-truncation). | | #3340 (#3342) | @rly09 | Persistent-state toast when a turn has saved memory / created-updated a skill. | | #3533 | @franksong2702 | `/reload-mcp` marked `cli_only` so the WebUI doesn't dispatch it as an LLM prompt. | ### Gate - Full pytest suite: **7681 passed, 0 failed** - ESLint: CLEAN · ruff: CLEAN · browser-smoke: CLEAN - Codex (regression): **SAFE TO SHIP** — confirmed the stash-conflict path never drops the stash / never restarts on conflict, auth Secure handles LAN-HTTP correctly with no header-forgery hole, `/reload-mcp` allowlisted, state-toast has a real backend writer + active-session guard, diagnostics leak no paths, TTS chunking preserves order. Co-authored-by: rodboev <rodboev@users.noreply.github.com> Co-authored-by: franksong2702 <franksong2702@users.noreply.github.com> Co-authored-by: lambyangzhao <lambyangzhao@users.noreply.github.com> Co-authored-by: rly09 <rly09@users.noreply.github.com>
75 lines
3.5 KiB
Python
75 lines
3.5 KiB
Python
from pathlib import Path
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
MESSAGES_JS = (ROOT / "static" / "messages.js").read_text(encoding="utf-8")
|
|
STREAMING_PY = (ROOT / "api" / "streaming.py").read_text(encoding="utf-8")
|
|
CHANGELOG = (ROOT / "CHANGELOG.md").read_text(encoding="utf-8")
|
|
|
|
|
|
def _tool_complete_listener_block() -> str:
|
|
start = MESSAGES_JS.index("source.addEventListener('tool_complete'")
|
|
end = MESSAGES_JS.index("source.addEventListener('approval'", start)
|
|
return MESSAGES_JS[start:end]
|
|
|
|
|
|
def test_tool_complete_notifies_on_persistent_state_writes():
|
|
assert "function _maybeNotifyPersistentStateSaved(tool)" in MESSAGES_JS
|
|
block = _tool_complete_listener_block()
|
|
|
|
assert "_maybeNotifyPersistentStateSaved(tc);" in block
|
|
assert block.index("tc.is_error=!!d.is_error;") < block.index("_maybeNotifyPersistentStateSaved(tc);")
|
|
assert block.index("if(!S.session||S.session.session_id!==activeSid) return;") < block.index("_maybeNotifyPersistentStateSaved(tc);")
|
|
assert block.index("_maybeNotifyPersistentStateSaved(tc);") < block.index("refreshOpenPreviewIfMutated")
|
|
|
|
|
|
def test_persistent_state_toast_classifier_is_write_only_and_deduped():
|
|
helper_start = MESSAGES_JS.index("function _persistentToastHasWriteIntent")
|
|
helper_end = MESSAGES_JS.index("function _persistentToastSkillName", helper_start)
|
|
helper = MESSAGES_JS[helper_start:helper_end]
|
|
|
|
assert "read|list|view|search|lookup|get|fetch|load|usage|toggle|delete|remove" in helper
|
|
assert "save|saved|write|wrote|written|update|updated|create|created|store|stored|persist|persisted|remember|remembered" in helper
|
|
assert "_persistentStateToastSeen.has(dedupeKey)" in MESSAGES_JS
|
|
assert "_persistentStateToastSeen.add(dedupeKey)" in MESSAGES_JS
|
|
assert "_showPersistentStateToast(isSkill?'skill':'memory'" in MESSAGES_JS
|
|
assert "if(isSkill&&!skillName)return;" in MESSAGES_JS
|
|
|
|
|
|
def test_persistent_state_toasts_use_existing_user_visible_labels():
|
|
notify_start = MESSAGES_JS.index("function _maybeNotifyPersistentStateSaved")
|
|
notify_end = MESSAGES_JS.index("function _selectedTextReplyT", notify_start)
|
|
notify = MESSAGES_JS[notify_start:notify_end]
|
|
|
|
assert "t('memory_saved')" in notify
|
|
assert "t('skill_created')" in notify
|
|
assert "t('skill_updated')" in notify
|
|
assert "showToast(itemName?`${base}: ${itemName}`:base,4200,'success')" in notify
|
|
assert "showToast(t('memory_saved'),3600,'success')" in notify
|
|
|
|
|
|
def test_backend_emits_state_saved_sse_from_file_snapshots():
|
|
assert "def _persistent_state_snapshot" in STREAMING_PY
|
|
assert "def _persistent_state_changes" in STREAMING_PY
|
|
assert '_persistent_state_before = _persistent_state_snapshot(_profile_home)' in STREAMING_PY
|
|
assert 'put("state_saved", {' in STREAMING_PY
|
|
assert '"kind": "memory"' in STREAMING_PY
|
|
assert '"kind": "skill"' in STREAMING_PY
|
|
|
|
|
|
def test_frontend_handles_state_saved_sse_and_reuses_dedupe():
|
|
start = MESSAGES_JS.index("source.addEventListener('state_saved'")
|
|
end = MESSAGES_JS.index("source.addEventListener('title'", start)
|
|
block = MESSAGES_JS[start:end]
|
|
|
|
assert "_showPersistentStateToast(d.kind, d.name||''" in block
|
|
assert "String(d.action||'').toLowerCase()==='created'" in block
|
|
assert "if((d.session_id||activeSid)!==activeSid) return;" in block
|
|
assert "'state_saved'" in MESSAGES_JS
|
|
|
|
|
|
def test_issue_3340_changelog_entry_present():
|
|
assert "#3340" in CHANGELOG
|
|
assert "saved memory" in CHANGELOG
|
|
assert "created/updated a skill" in CHANGELOG
|