From d45bc32c8dfa6862fddcb8cff69d2c4b74153e01 Mon Sep 17 00:00:00 2001
From: nesquena-hermes <[email protected]>
Date: Sat, 30 May 2026 00:10:29 +0000
Subject: [PATCH] test: update #2246 question-jump assertions for #3114 (button
 on all assistant msgs with resolvable target)

---
 tests/test_issue2246_question_jump.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/test_issue2246_question_jump.py b/tests/test_issue2246_question_jump.py
index e06ce874..c4f81460 100644
--- a/tests/test_issue2246_question_jump.py
+++ b/tests/test_issue2246_question_jump.py
@@ -15,8 +15,14 @@ def test_assistant_footer_gets_completed_turn_question_jump_button():
     assert "questionRawIdxByAssistantRawIdx.set(entry.rawIdx,lastQuestionRawIdx)" in UI_JS
     assert "row.id=_userMessageDomId(rawIdx)" in UI_JS
     assert "const isTurnFinalAssistant=!isUser&&(!nextRendered||!nextRendered.m||nextRendered.m.role!=='assistant')" in UI_JS
-    assert "(!isUser&&!m._live&&isTurnFinalAssistant)" in UI_JS
-    assert "_questionJumpButtonHtml(questionRawIdxByAssistantRawIdx.get(rawIdx))" in UI_JS
+    # #3114 superseded the turn-final-only gate: the jump-to-question button now
+    # renders on every assistant message that has a resolvable question target,
+    # not just the turn-final one (multi-step turns otherwise lost the affordance
+    # on intermediate assistant bubbles). The button is gated on a non-null
+    # resolved target instead of isTurnFinalAssistant.
+    assert "const _qJumpTarget=(!isUser&&!m._live)?questionRawIdxByAssistantRawIdx.get(rawIdx):undefined;" in UI_JS
+    assert "const questionJumpBtn = (_qJumpTarget!==undefined&&_qJumpTarget!==null)" in UI_JS
+    assert "_questionJumpButtonHtml(_qJumpTarget)" in UI_JS
     assert "msg-question-jump-btn" in UI_JS