From 9c3e37d2ee3b5aaec2203e55df737d86dc5cc706 Mon Sep 17 00:00:00 2001 From: Colin Chang Date: Wed, 20 May 2026 23:24:10 +0800 Subject: [PATCH] fix: custom_providers models allowlist takes priority over live /v1/models fetch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Custom providers that have a curated models: list in config.yaml (e.g. ZenMux gateways) should show ONLY those configured models in the picker dropdown, not the full /v1/models catalog. Before this fix, _named_custom_groups unconditionally called _read_custom_endpoint_models() which would pull hundreds of models from aggregator gateways and overwrite the user's curated list. Now the build checks if the custom_provider entry has a non-empty models dict/list in config.yaml — if so, it skips the live fetch and uses only the configured models (same behavior as hermes-agent model_switch.py Section 4 patch). Closes: configure-model-list-should-be-authoritative --- api/config.py | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/api/config.py b/api/config.py index 225c8e06..65b418d5 100644 --- a/api/config.py +++ b/api/config.py @@ -3364,9 +3364,30 @@ def get_available_models() -> dict: _cp_key_env = str(_cp.get("key_env") or "").strip() if _cp_key_env: _cp_api_key = str(os.getenv(_cp_key_env) or "").strip() + + # Check if user has configured models in config.yaml — + # configured models take priority over live /v1/models + # discovery (same as hermes-agent model_switch.py Section 4 + # patch). Without this check, ZenMux and similar aggregator + # gateways would show hundreds of online models instead of + # the user's curated list. + _cp_configured_models = _cp.get("models") + _cp_has_configured_models = ( + isinstance(_cp_configured_models, (dict, list)) + and len(_cp_configured_models) > 0 + ) _live_models = auto_detected_models_by_provider.get(_slug) _live_error = None - if _live_models is None: + if _cp_has_configured_models: + # Skip the live /v1/models probe when an allowlist + # exists — the curated list wins and probe failures + # should not surface as a user-facing diagnostic in + # that case. Still respect any pre-warm result that + # ``auto_detected_models_by_provider`` already + # populated (cheap to keep). + if _live_models is None: + _live_models = [] + elif _live_models is None: _live_models, _live_error = _read_custom_endpoint_models( _cp_base_url, _slug,