Teknium
fb05f5d4b5
fix(mcp): validate remote URLs up-front with a clear error ( #27105 )
...
Port from anomalyco/opencode#25019 ("fix: handle invalid mcp urls").
Previously: a typo in `config.yaml` (missing scheme, wrong scheme,
empty string, non-string value) slipped past `_is_http()` and hit
`httpx.URL(url)` or `streamablehttp_client(url, ...)` deep in the
transport layer. That raised a generic exception which went through
the reconnect-backoff loop, so a bad URL caused _MAX_INITIAL_CONNECT_RETRIES
attempts with doubling backoff — about a minute of pointless retries
plus an opaque error — before the server was marked failed.
Now: we validate the URL once, at the top of `run()`, before
entering the retry loop. A malformed URL raises `InvalidMcpUrlError`
(a `ValueError` subclass) with a message that names the offending
server and explains exactly what was wrong. `_ready` is set and
`_error` is populated, so `start()` re-raises and the server shows
up as failed in `hermes mcp list` without any backoff burn.
Validation rules:
- Must be a string (rejects None, dict, int)
- Must be non-empty (rejects '' and whitespace-only)
- Scheme must be http or https (rejects file://, ws://, stdio://)
- Must have a non-empty host (rejects http:/// , http://:8080 )
Tests (21 new cases in tests/tools/test_mcp_invalid_url.py):
- TestValidUrlsAccepted: http, https, IPv6, ports, paths, query strings
- TestInvalidUrlsRejected: every rejection path above + clear error text
- TestErrorIsValueError: downstream code catching ValueError still works
E2E verified: a misconfigured server with `url: not-a-valid-url`
now fails in <0.001s with the clear error, instead of minutes of retries.
Doesn't touch stdio servers (they use `command`, not `url`) — the
validator only fires when `_is_http()` returns True.
2026-05-16 13:06:56 -07:00
..
2026-04-29 20:05:32 -07:00
2026-03-23 07:43:12 -07:00
2026-05-08 14:55:40 -07:00
2026-05-08 14:55:40 -07:00
2026-05-16 01:24:25 -07:00
2026-05-04 04:45:03 -07:00
2026-05-12 15:14:49 -07:00
2026-05-12 15:14:49 -07:00
2026-04-24 03:46:46 -07:00
2026-04-17 16:05:04 -07:00
2026-04-24 03:46:46 -07:00
2026-05-13 22:07:02 -07:00
2026-04-08 13:44:58 -07:00
2026-04-16 04:19:34 -07:00
2026-05-09 13:35:39 -07:00
2026-04-20 00:32:09 -07:00
2026-03-28 17:25:04 -07:00
2026-05-10 07:37:55 -07:00
2026-04-10 13:05:44 -07:00
2026-05-08 14:27:40 -07:00
2026-04-26 09:57:58 -07:00
2026-05-06 03:41:21 -07:00
2026-05-08 14:27:40 -07:00
2026-04-01 12:03:56 -07:00
2026-05-07 05:38:05 -07:00
2026-04-30 20:33:33 -07:00
2026-05-10 07:37:55 -07:00
2026-04-11 02:58:48 -07:00
2026-05-09 17:53:13 -07:00
2026-05-14 07:59:12 -07:00
2026-02-27 03:29:26 -05:00
2026-05-13 22:54:21 -07:00
2026-05-08 14:27:40 -07:00
2026-05-08 14:27:40 -07:00
2026-05-08 14:27:40 -07:00
2026-05-08 14:55:40 -07:00
2026-05-14 14:52:15 -07:00
2026-03-27 04:03:00 -07:00
2026-04-10 03:44:43 -07:00
2026-05-08 14:55:40 -07:00
2026-05-08 07:30:14 -07:00
2026-02-26 13:55:54 +03:00
2026-05-15 12:35:07 -07:00
2026-05-12 16:31:46 -07:00
2026-03-02 04:34:21 -08:00
2026-05-07 06:41:42 -07:00
2026-04-24 04:58:32 -07:00
2026-03-26 14:50:26 -07:00
2026-05-16 01:00:27 -07:00
2026-05-07 05:11:09 -07:00
2026-04-29 16:16:43 +10:00
2026-04-14 21:20:37 -07:00
2026-05-07 06:17:49 -07:00
2026-05-07 04:53:10 -07:00
2026-04-21 06:14:25 -07:00
2026-04-17 19:04:11 -07:00
2026-05-05 04:54:17 -07:00
2026-05-04 12:37:09 -07:00
2026-04-17 19:26:40 -07:00
2026-04-27 00:17:26 -07:00
2026-04-23 15:11:52 -07:00
2026-04-21 16:41:26 -07:00
2026-05-09 11:12:03 -07:00
2026-04-10 03:01:46 -07:00
2026-04-10 21:14:32 -07:00
2026-04-20 00:58:16 -07:00
2026-04-08 17:23:15 -07:00
2026-05-08 16:59:24 -07:00
2026-04-13 05:15:05 -07:00
2026-03-14 11:27:02 -07:00
2026-04-21 02:03:46 -07:00
2026-05-11 06:56:30 -07:00
2026-05-04 05:08:51 -07:00
2026-03-04 18:34:16 +03:00
2026-04-13 04:45:07 -07:00
2026-05-15 01:33:13 -07:00
2026-04-23 03:01:18 -07:00
2026-04-21 13:35:31 -07:00
2026-04-28 22:16:08 -07:00
2026-04-14 02:18:38 -07:00
2026-05-10 16:14:43 -07:00
2026-05-14 08:03:40 -07:00
2026-03-27 15:28:19 -07:00
2026-04-19 11:27:50 -07:00
2026-04-29 07:22:33 -07:00
2026-05-04 15:31:47 -07:00
2026-05-15 16:25:31 -07:00
2026-04-29 23:18:55 -07:00
2026-04-23 05:15:37 -07:00
2026-04-09 16:24:53 -07:00
2026-04-16 12:36:49 -07:00
2026-04-16 12:36:49 -07:00
2026-04-15 13:29:05 -07:00
2026-04-16 12:36:49 -07:00
2026-05-07 07:04:38 -07:00
2026-04-21 05:19:03 -07:00
2026-04-29 20:05:32 -07:00
2026-05-07 06:33:57 -07:00
2026-05-07 07:14:16 -07:00
2026-05-16 13:06:56 -07:00
2026-04-19 16:31:07 -07:00
2026-04-19 16:31:07 -07:00
2026-04-16 21:57:10 -07:00
2026-04-16 21:57:10 -07:00
2026-05-07 05:35:33 -07:00
2026-05-07 04:56:13 -07:00
2026-05-15 14:00:01 -07:00
2026-04-16 21:57:10 -07:00
2026-05-07 07:08:04 -07:00
2026-05-08 14:27:40 -07:00
2026-05-15 14:00:01 -07:00
2026-04-16 21:57:10 -07:00
2026-04-04 10:18:57 -07:00
2026-05-07 06:32:45 -07:00
2026-05-16 01:04:28 -07:00
2026-05-07 07:39:50 -07:00
2026-04-14 10:18:05 -07:00
2026-05-07 07:03:21 -07:00
2026-04-13 16:32:04 -07:00
2026-05-08 09:27:26 -07:00
2026-05-08 09:27:26 -07:00
2026-04-23 15:14:11 -07:00
2026-04-12 06:18:05 +05:30
2026-04-29 07:22:33 -07:00
2026-04-10 03:01:46 -07:00
2026-04-12 00:36:22 -07:00
2026-04-05 12:46:07 -07:00
2026-04-22 14:45:50 -07:00
2026-04-10 16:47:44 -07:00
2026-05-15 19:31:00 +05:30
2026-04-13 16:32:04 -07:00
2026-05-13 17:32:22 -07:00
2026-04-23 15:11:52 -07:00
2026-05-07 07:03:21 -07:00
2026-03-17 02:02:57 -07:00
2026-04-15 17:37:43 -07:00
2026-05-11 06:44:58 -07:00
2026-05-09 14:36:58 -07:00
2026-04-26 11:55:02 -07:00
2026-04-20 13:24:15 -07:00
2026-03-16 19:01:39 +03:00
2026-04-10 03:44:43 -07:00
2026-04-01 04:19:19 -07:00
2026-05-05 05:43:10 -07:00
2026-05-08 14:55:40 -07:00
2026-04-01 04:19:19 -07:00
2026-05-07 06:13:37 -07:00
2026-03-04 05:30:43 -08:00
2026-03-02 02:00:09 -08:00
2026-04-23 06:20:47 -07:00
2026-05-09 17:52:12 -07:00
2026-05-09 17:52:12 -07:00
2026-04-23 05:09:08 -07:00
2026-05-13 13:29:28 -07:00
2026-04-29 21:56:47 -07:00
2026-04-24 07:06:11 -07:00
2026-04-30 04:32:28 -07:00
2026-04-20 03:07:32 -07:00
2026-03-04 17:23:23 +03:00
2026-04-16 19:39:21 -07:00
2026-04-19 16:53:11 -07:00
2026-05-09 17:53:35 -07:00
2026-04-04 16:57:24 -07:00
2026-04-19 16:47:20 -07:00
2026-04-08 21:37:51 -07:00
2026-04-20 23:20:33 -07:00
2026-04-29 07:22:33 -07:00
2026-05-09 14:46:34 -07:00
2026-03-29 21:51:44 -07:00
2026-04-09 16:24:53 -07:00
2026-04-29 07:22:33 -07:00
2026-04-30 20:38:09 -07:00
2026-04-08 17:23:15 -07:00
2026-05-15 20:29:28 -07:00
2026-04-11 16:22:50 -07:00
2026-04-26 19:02:55 -07:00
2026-04-23 21:51:19 -07:00
2026-05-09 18:44:58 -07:00
2026-05-15 12:11:32 -07:00
2026-05-13 10:31:22 -07:00
2026-05-13 17:32:22 -07:00
2026-04-30 02:53:20 -07:00
2026-05-15 12:11:32 -07:00
2026-04-16 14:23:16 -07:00
2026-05-13 17:32:22 -07:00
2026-04-21 17:49:39 -07:00
2026-05-11 23:02:15 -07:00
2026-04-30 02:53:20 -07:00
2026-05-13 22:04:28 -07:00
2026-05-15 01:52:48 -07:00
2026-05-08 14:55:40 -07:00
2026-05-04 00:04:36 +05:30
2026-05-13 16:39:41 -07:00
2026-05-13 16:39:41 -07:00
2026-05-13 16:39:41 -07:00
2026-05-12 13:59:22 -04:00
2026-04-20 00:32:09 -07:00
2026-05-04 01:36:07 -07:00
2026-04-09 16:24:53 -07:00
2026-04-25 06:41:58 -07:00
2026-05-13 22:31:28 -07:00
2026-05-13 22:31:28 -07:00
2026-05-13 22:31:28 -07:00
2026-05-13 22:31:28 -07:00
2026-05-13 22:31:28 -07:00
2026-04-09 13:17:06 -07:00
2026-05-13 22:31:28 -07:00
2026-03-01 01:54:27 +03:00
2026-05-12 01:02:25 -07:00
2026-04-24 03:46:46 -07:00
2026-05-16 00:58:27 -07:00
2026-04-30 20:37:37 -07:00
2026-04-24 03:46:46 -07:00