mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-21 03:39:54 +00:00
23344a9a3c
Ship LSP semantic diagnostics as a bundled plugin (plugins/lsp/) using existing hook system. Zero lines of core code modified. Plugin wiring: - pre_tool_call: capture LSP baseline before write_file/patch - transform_tool_result: inject diagnostics into tool result JSON - on_session_start/on_session_end + atexit: lifecycle management Key design: - Baselines keyed by (session_id, abs_path) for concurrent safety - Diagnostics added as 'lsp_diagnostics' JSON field (preserves shape) - Per-file workspace detection (no static session-start gate) - V4A multi-file patch skipped for MVP - Short timeout (3s) — cold start degrades gracefully - os.path.exists heuristic for Docker/SSH backend skip - First relevant write with no server → INFO log with install hint Tests: 77/77 pass including: - Protocol framing, reporter formatting, workspace resolution - Client E2E against mock LSP server (live_system_guard_bypass) - Eventlog steady-state silence contract - Backend-gate heuristic (local vs non-local paths) - Full hook flow integration (pre→write→transform with diagnostics) Source: PR #24168 by @teknium1, PR #24155 by @OutThisLife Co-authored-by: Teknium <127238744+teknium1@users.noreply.github.com>
200 lines
6.9 KiB
Python
200 lines
6.9 KiB
Python
"""Tests for the structured logging dedup model.
|
|
|
|
The contract: a 1000-write session in one project should emit exactly
|
|
ONE INFO line ("active for <root>") at the default INFO threshold.
|
|
Steady-state events stay at DEBUG; first-time-seen events surface
|
|
once at INFO/WARNING.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
|
|
import pytest
|
|
|
|
from plugins.lsp import eventlog
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset():
|
|
eventlog.reset_announce_caches()
|
|
yield
|
|
eventlog.reset_announce_caches()
|
|
|
|
|
|
@pytest.fixture
|
|
def caplog_lsp(caplog):
|
|
caplog.set_level(logging.DEBUG, logger="hermes.lint.lsp")
|
|
return caplog
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Steady-state silence (DEBUG)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_clean_emits_at_debug(caplog_lsp):
|
|
for _ in range(10):
|
|
eventlog.log_clean("pyright", "/proj/x.py")
|
|
info_records = [r for r in caplog_lsp.records if r.levelno >= logging.INFO]
|
|
debug_records = [r for r in caplog_lsp.records if r.levelno == logging.DEBUG]
|
|
assert info_records == []
|
|
assert len(debug_records) == 10
|
|
|
|
|
|
def test_disabled_emits_at_debug(caplog_lsp):
|
|
eventlog.log_disabled("pyright", "/x.py", "feature off")
|
|
eventlog.log_disabled("pyright", "/x.py", "ext not mapped")
|
|
assert all(r.levelno == logging.DEBUG for r in caplog_lsp.records)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# State transitions: INFO once, DEBUG thereafter
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_active_for_fires_once_per_root(caplog_lsp):
|
|
for _ in range(50):
|
|
eventlog.log_active("pyright", "/proj")
|
|
info_records = [
|
|
r for r in caplog_lsp.records
|
|
if r.levelno == logging.INFO and "active for" in r.getMessage()
|
|
]
|
|
assert len(info_records) == 1
|
|
|
|
|
|
def test_active_for_fires_per_distinct_root(caplog_lsp):
|
|
eventlog.log_active("pyright", "/proj-a")
|
|
eventlog.log_active("pyright", "/proj-b")
|
|
info = [r for r in caplog_lsp.records if r.levelno == logging.INFO]
|
|
assert len(info) == 2
|
|
|
|
|
|
def test_active_for_separate_per_server(caplog_lsp):
|
|
eventlog.log_active("pyright", "/proj")
|
|
eventlog.log_active("typescript", "/proj")
|
|
info = [r for r in caplog_lsp.records if r.levelno == logging.INFO]
|
|
assert len(info) == 2
|
|
|
|
|
|
def test_no_project_root_fires_once_per_path(caplog_lsp):
|
|
for _ in range(5):
|
|
eventlog.log_no_project_root("pyright", "/orphan.py")
|
|
info = [r for r in caplog_lsp.records if r.levelno == logging.INFO]
|
|
assert len(info) == 1
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Diagnostics events fire INFO every time
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_diagnostics_always_info(caplog_lsp):
|
|
for i in range(5):
|
|
eventlog.log_diagnostics("pyright", f"/x{i}.py", 1)
|
|
info = [r for r in caplog_lsp.records if r.levelno == logging.INFO]
|
|
assert len(info) == 5
|
|
assert all("diags" in r.getMessage() for r in info)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Action-required: WARNING once, DEBUG thereafter (or per call for novel events)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_server_unavailable_warns_once_per_binary(caplog_lsp):
|
|
for _ in range(20):
|
|
eventlog.log_server_unavailable("pyright", "pyright-langserver")
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 1
|
|
assert "pyright-langserver" in warns[0].getMessage()
|
|
|
|
|
|
def test_server_unavailable_separate_per_binary(caplog_lsp):
|
|
eventlog.log_server_unavailable("pyright", "pyright-langserver")
|
|
eventlog.log_server_unavailable("typescript", "typescript-language-server")
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 2
|
|
|
|
|
|
def test_no_server_configured_warns_once(caplog_lsp):
|
|
for _ in range(10):
|
|
eventlog.log_no_server_configured("pyright")
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 1
|
|
|
|
|
|
def test_timeout_warns_every_call(caplog_lsp):
|
|
for _ in range(3):
|
|
eventlog.log_timeout("pyright", "/x.py")
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 3
|
|
|
|
|
|
def test_server_error_warns_every_call(caplog_lsp):
|
|
for _ in range(3):
|
|
eventlog.log_server_error("pyright", "/x.py", RuntimeError("boom"))
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 3
|
|
|
|
|
|
def test_spawn_failed_warns(caplog_lsp):
|
|
eventlog.log_spawn_failed("pyright", "/proj", FileNotFoundError("nope"))
|
|
warns = [r for r in caplog_lsp.records if r.levelno == logging.WARNING]
|
|
assert len(warns) == 1
|
|
assert "spawn/initialize failed" in warns[0].getMessage()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Format: log lines all carry the lsp[<server_id>] prefix for grep
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_log_lines_use_lsp_prefix(caplog_lsp):
|
|
eventlog.log_clean("pyright", "/x.py")
|
|
eventlog.log_active("pyright", "/proj")
|
|
eventlog.log_diagnostics("typescript", "/y.ts", 2)
|
|
for r in caplog_lsp.records:
|
|
assert r.getMessage().startswith("lsp[")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Steady-state contract: 1000 clean writes → 1 INFO at most
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_thousand_clean_writes_emit_one_info(caplog_lsp):
|
|
"""A long session writes lots of files cleanly; agent.log should
|
|
show ONE 'active for' INFO and zero other INFO lines."""
|
|
eventlog.log_active("pyright", "/proj")
|
|
for _ in range(1000):
|
|
eventlog.log_clean("pyright", "/proj/x.py")
|
|
info_records = [r for r in caplog_lsp.records if r.levelno == logging.INFO]
|
|
assert len(info_records) == 1
|
|
assert "active for" in info_records[0].getMessage()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Path shortening
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_short_path_uses_relative_when_inside_cwd(tmp_path, monkeypatch):
|
|
monkeypatch.chdir(tmp_path)
|
|
sub = tmp_path / "x.py"
|
|
sub.write_text("")
|
|
out = eventlog._short_path(str(sub))
|
|
assert out == "x.py"
|
|
|
|
|
|
def test_short_path_keeps_absolute_when_outside(tmp_path, monkeypatch):
|
|
monkeypatch.chdir(tmp_path / "a") if (tmp_path / "a").exists() else None
|
|
monkeypatch.chdir(tmp_path)
|
|
other = "/var/log/foo.txt"
|
|
out = eventlog._short_path(other)
|
|
# Outside cwd: keeps absolute (no leading "../")
|
|
assert out == "/var/log/foo.txt" or not out.startswith("..")
|
|
|
|
|
|
def test_short_path_handles_empty_string():
|
|
assert eventlog._short_path("") == ""
|